Using testcontainer to create a test framework for testing - #167
Merged
Conversation
zymap
added
type/enhancement
Member
Author
|
@sijie @wolfstudy PTAL. Thanks. |
|
also add @EronWright for helping review it. |
--- Master Issue: streamnative#163 *Motivation* Currently, we are using an external pulsar standalone to test the Pulsarctl. We need to enhancement the test to ensure the Pulsarctl can work well in a complete pulsar cluster. *Modifications* - Using testcontainer to test the pulsarctl.
Member
Author
|
@sijie PTAL. Thanks |
EronWright
reviewed
Jan 9, 2020
EronWright
left a comment
EronWright
left a comment
Contributor
There was a problem hiding this comment.
Very slick test framework!
Member
Author
|
Hi @EronWright , thank you for your review. I addressed your comments and please take look again when you have time. |
sijie
approved these changes
Jan 11, 2020
tisonkun
pushed a commit
to tisonkun/pulsar-client-go
that referenced
this pull request
Aug 15, 2023
…ive/pulsarctl#167) * Using testcontainer to create a test framework for testing --- Master Issue: streamnative/pulsarctl#163 *Motivation* Currently, we are using an external pulsar standalone to test the Pulsarctl. We need to enhancement the test to ensure the Pulsarctl can work well in a complete pulsar cluster. *Modifications* - Using testcontainer to test the pulsarctl. * * Move direcotories * * Address comments
tisonkun
pushed a commit
to apache/pulsar-client-go
that referenced
this pull request
Aug 16, 2023
…ive/pulsarctl#167) * Using testcontainer to create a test framework for testing --- Master Issue: streamnative/pulsarctl#163 *Motivation* Currently, we are using an external pulsar standalone to test the Pulsarctl. We need to enhancement the test to ensure the Pulsarctl can work well in a complete pulsar cluster. *Modifications* - Using testcontainer to test the pulsarctl. * * Move direcotories * * Address comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Master Issue: #163
Motivation
Currently, we are using an external pulsar standalone to
test the Pulsarctl. We need to enhancement the test to
ensure the Pulsarctl can work well in a complete pulsar
cluster.
Modifications